Cleanup no longer needed rocq-wrap.sh - #304
Merged
Merged
Conversation
Since dune build requires dune >= 3.21 and uses rocq lang 0.11, it is able to compile without the coq* compat binaries that the rocq-wrap.sh script was faking.
Contributor
|
This broke the coq-stdlib.dev package, see rocq-prover/opam#3837. |
Contributor
Author
|
Wow, this core-dev coq-stdlib package seems pretty outdated. @RalfJung Immediate fix for you: depend on rocq-stdlib, not coq-stdlib (it's the same, just not broken). Or wait for rocq-prover/opam#3838 to fix it. |
Contributor
|
We don't depend on it directly but it is pulled in transitively by some dependency.
Thanks for the quick fix!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dune build requires dune >= 3.21 and uses rocq lang 0.11, it is able to compile without the coq* compat binaries that the rocq-wrap.sh script was faking.